Bugfix: "internal error" message shown when trying to step from a state with multiple target edges #77
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lts in an "internal error"
karoliineh
changed the title
karoliineh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting a breakpoint to the paper demo on line 21, and starting the debugger, stepping results in an "internal error". This is caused by
targetEdgegetting anullvalue, after whichtargetEdge.nodeId()is called, causing aNullPointerException. Without this proposed fix, the debugger will show a notification box with "Internal error" but will recover and step forward once a stepping button is pushed again.The bug is probably caused by the fix from #74, where now the return statement
return targetEdgesByCFGNode.size() == 1 ? targetEdgesByCFGNode.get(0) : null;of functionfindTargetEdgeis reached (previously an exception was always thrown), and thus, thetargetEdgeinstepAllThreadsIntoMatchingEdgecan get anullvalue.